[Search] FTR tests and fixes for Getting Started page #241442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seialkali
added
the
release_note:skip
seialkali
added
backport:skip
wildemat
reviewed
Oct 31, 2025
...earch/plugins/search_getting_started/public/components/tutorials/console_tutorials_group.tsx
Outdated
Show resolved
Hide resolved
wildemat
reviewed
Oct 31, 2025
x-pack/solutions/search/test/functional_search/tests/search_getting_started.ts
Outdated
Show resolved
Hide resolved
dmlemeshko
approved these changes
Oct 31, 2025
Member
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
x-pack/solutions/search/test/serverless/functional/configs/config.ts changes LGTM
wildemat
reviewed
Oct 31, 2025
x-pack/solutions/search/test/functional_search/tests/search_getting_started.ts
Outdated
Show resolved
Hide resolved
wildemat
reviewed
Oct 31, 2025
x-pack/solutions/search/test/functional_search/tests/search_getting_started.ts
Outdated
Show resolved
Hide resolved
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9695[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed. |
seialkali
force-pushed
the
getting-started-ftr-page-object
branch
from
bf04daf to
e148107
Compare
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9697[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed. |
wildemat
reviewed
Oct 31, 2025
seialkali
force-pushed
the
getting-started-ftr-page-object
branch
from
e148107 to
19868e2
Compare
jbudz
approved these changes
Oct 31, 2025
seialkali
force-pushed
the
getting-started-ftr-page-object
branch
from
19868e2 to
e3ab2e0
Compare
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9702[❌] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 0/25 tests passed. |
seialkali
force-pushed
the
getting-started-ftr-page-object
branch
from
e3ab2e0 to
1ed17e0
Compare
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9720[❌] x-pack/solutions/search/test/functional_search/config/config.feature_flags.ts: 0/25 tests passed. |
seialkali
force-pushed
the
getting-started-ftr-page-object
branch
from
1ed17e0 to
a417cda
Compare
seialkali
commented
Nov 4, 2025
| searchHomepage: { | ||
| pathname: '/app/elasticsearch/home', | ||
| }, | ||
| searchGettingStarted: { |
Contributor
Author
There was a problem hiding this comment.
I defined this in the base config instead of the feature flag config because it will need to be added here anyway once the FF is removed
seialkali
commented
Nov 4, 2025
| searchQueryRules: { | ||
| pathname: '/app/elasticsearch/query_rules', | ||
| }, | ||
| searchGettingStarted: { |
Contributor
Author
There was a problem hiding this comment.
I defined this in the base config instead of the feature flag config because it will need to be added here anyway once the FF is removed
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9741[❌] x-pack/solutions/search/test/functional_search/config/config.feature_flags.ts: 24/25 tests passed. |
seialkali
force-pushed
the
getting-started-ftr-page-object
branch
from
a417cda to
0e0b1b0
Compare
seialkali
force-pushed
the
getting-started-ftr-page-object
branch
from
0e0b1b0 to
955b64d
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9747[✅] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 25/25 tests passed. |
wildemat
approved these changes
Nov 5, 2025
Contributor
wildemat
left a comment
wildemat
left a comment
There was a problem hiding this comment.
Great job getting through this
TattdCodeMonkey
approved these changes
Nov 5, 2025
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Nov 5, 2025
## Summary This PR adds FTR test for the Getting Started page, as well as a fix for a bug that was picked up by the tests. NOTE: I'm aware we should be moving over to Scout, but I thought it might be easier (for me at least) to get these tests up and running first and then convert them to Scout afterwards. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] ~The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~ - [ ] ~Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Nov 5, 2025
## Summary This PR adds FTR test for the Getting Started page, as well as a fix for a bug that was picked up by the tests. NOTE: I'm aware we should be moving over to Scout, but I thought it might be easier (for me at least) to get these tests up and running first and then convert them to Scout afterwards. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] ~The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~ - [ ] ~Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds FTR test for the Getting Started page, as well as a fix for a bug that was picked up by the tests.
NOTE: I'm aware we should be moving over to Scout, but I thought it might be easier (for me at least) to get these tests up and running first and then convert them to Scout afterwards.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.The PR description includes the appropriate Release Notes section, and the correctrelease_note:*label is applied per the guidelinesReview the backport guidelines and apply applicablebackport:*labels.